Skip to content

Fix Linux build issues #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WillNilges wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Linux build issues #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f248dc
Add UNAME_S variable to allow Linux to find files
WillNilges Nov 21, 2022
e5dc2fc
Add gitignore
WillNilges Nov 21, 2022
14e4854
Properly reference libopenmp for Ubuntu
WillNilges Nov 21, 2022
ee1ecbd
Update gitignore
WillNilges Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
build/
times.csv
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ SOURCE_FILES :=
ifeq ($(OS), Windows_NT)
SOURCE_FILES = $(shell find $(SOURCE_DIR) -name *.cpp -o -name *.cu)
else
UNAME_S = $(shell uname -s)
ifeq ($(UNAME_S), Linux)
SOURCE_FILES = $(shell find $(SOURCE_DIR) -name '*.cpp' -o -name '*.cu')
else
Expand All @@ -20,7 +21,7 @@ list_sources:

build:
mkdir -p ${BUILD_DIR}
nvcc -x cu ${SOURCE_FILES} --std=c++11 -lineinfo -o ${BUILD_DIR}/${EXEC_FILE} -Xcompiler -openmp
nvcc -x cu ${SOURCE_FILES} --std=c++11 -lineinfo -o ${BUILD_DIR}/${EXEC_FILE} -Xcompiler -fopenmp
Copy link
Copy Markdown
Owner

@palucdev palucdev Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-fopenmp flag is throwing alot of warnings when building on Windows. Looks like compiler differences. -fopenmp is connected with gcc, windows nvcc command supports only cl.exe. It will be good to differentiate this flag based upon OS (like in SOURCE_FILE initialization).


run:
./${BUILD_DIR}/${EXEC_FILE} $(file) $(threads) $(blocks) -d $(device_id)
Expand Down