refactor: make code more idiomatic #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use iterator chains instead of manual index loops in build_indexes - Use .map(...).unwrap_or_default() pattern in helper methods - Use iterator chaining in all_elements() instead of manual Vec building - Use bytes().zip().take_while().count() for common_prefix_len - Fix get_element to use O(1) lookup (store ElementType with index) - Skip asset test when frontend not built (conditional check) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
Author
|
@panbanda Ready for review - idiomatic Rust improvements with no behavioral changes. |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
build_indexes.map(...).unwrap_or_default()pattern in helper methodsall_elements()instead of manual Vec buildingbytes().zip().take_while().count()forcommon_prefix_lenget_elementto use O(1) lookup (store ElementType with index)Test plan
cargo testGenerated with Claude Code