feat: implement build command with real parser and exporter #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update cli/build.rs to use actual Parser and Exporter instead of placeholder implementations - Unify exporter module to use model::Model instead of duplicate types - Remove redundant Model type definitions from exporter/mod.rs - Update exporter tests to use crate::model types - Make test_export_html_asset_files conditional on frontend build - Adjust build tests to reflect that image export is not yet implemented The build command now properly parses c4.mod.yaml files and exports HTML/JSON using the real model data. Image export remains a stub requiring Playwright integration. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
Author
|
@panbanda Ready for review. This PR implements the build command properly and unifies the model types across the codebase. |
panbanda
added a commit
that referenced
this pull request
Jan 11, 2026
The elements_by_id index was storing (path -> vec_index) but the get_element method was discarding the index and doing a linear search through the element vectors anyway. This change: - Stores (ElementType, index) in elements_by_id instead of just index - Rewrites get_element to use direct array indexing based on the stored element type, achieving true O(1) lookup - Uses enumerate() instead of manual index tracking in build_indexes For models with many elements, this provides significant performance improvement for element lookups. Also includes the conditional asset test fix from PR #8. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cli/build.rs) to use actual Parser and Exporter instead of placeholder/stub implementationsmodel::Modelinstead of maintaining duplicate type definitionstest_export_html_asset_filestest by making it conditional on frontend build availabilityChanges
cli/build.rsc4.mod.yamlusing the realParserfrom the parser moduleExporterfrom the exporter module for HTML and JSON exportexporter/mod.rsModel,Person,SoftwareSystem,Container,Component,Relationship,Flow,Deploymenttype definitionscrate::model::Modeldirectlyexporter/html.rs,exporter/json.rs,exporter/images.rscrate::modeltypes instead of the removed duplicate typesTest changes
test_export_html_asset_filesnow skips gracefully when frontend assets aren't built (allowscargo testduring development withoutmake build)Test plan
cargo clippypasses with no warningscargo fmt --checkpassesGenerated with Claude Code