fix: churn empty when --since all, add file path to cohesion table #339
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The churn analyzer passed `--since=4294967295 days` to git when report generate used --since all (u32::MAX sentinel). Git cannot parse that value and returns 0 commits, producing empty churn data. Now passes None (no --since flag) when days is u32::MAX, which correctly returns full history. Also adds the file path column to the cohesion table in the HTML report so classes with the same name from different files (e.g. Ruby reopened modules) are distinguishable. Co-Authored-By: claude-flow <ruv@ruv.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
report generateuses--since all,parse_since_to_daysreturnsNonewhich falls back tou32::MAX(4294967295). The churn analyzer was passing--since=4294967295 daystogit log, which git cannot parse, returning 0 commits and producing empty churn data in the report. Now treatsu32::MAXas a sentinel for "all history" and passes no--sinceflag to git.ApolloFederation) are distinguishable.Test plan
omen report generateproduces non-emptychurn.jsonwith--since all(default)cargo test analyzers::churnpasses