API: implement Period(|Dtype|Array|Index).unit, remove ._freqstr#64155
Open
jbrockmendel wants to merge 12 commits into
Open
API: implement Period(|Dtype|Array|Index).unit, remove ._freqstr#64155jbrockmendel wants to merge 12 commits into
jbrockmendel wants to merge 12 commits into
Conversation
jbrockmendel
force-pushed
the
api-unit
branch
from
d150285 to
2793933
Compare
Closed
jbrockmendel
force-pushed
the
api-unit
branch
2 times, most recently
from
9f66c50 to
26ebe11
Compare
mroeschke
reviewed
Feb 16, 2026
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Looks pretty good. Would need a whatsnew note for v3.1.0.rst
jbrockmendel
force-pushed
the
api-unit
branch
from
b48613c to
b2dcbcd
Compare
Member
Author
|
Turning this into a draft so I can post an issue discussing API options. I still think this is the right way to go, but there are reasonable alternatives. |
Member
Author
|
xref #64174 to warm my cold feet. |
jbrockmendel
force-pushed
the
api-unit
branch
from
b54e16b to
bd9f04d
Compare
jbrockmendel
force-pushed
the
api-unit
branch
2 times, most recently
from
34b6472 to
4073ba9
Compare
jbrockmendel
force-pushed
the
api-unit
branch
3 times, most recently
from
cb998e1 to
12a7e8b
Compare
jbrockmendel
force-pushed
the
api-unit
branch
2 times, most recently
from
75f6184 to
66a898b
Compare
jbrockmendel
force-pushed
the
api-unit
branch
3 times, most recently
from
9179855 to
75156d1
Compare
mroeschke
approved these changes
Apr 18, 2026
jbrockmendel
force-pushed
the
api-unit
branch
2 times, most recently
from
601e9fe to
5521161
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed on last week's dev call. This PR adds the attribute everywhere it will be needed. Then we'll start deprecating freq and freqstr (including rebasing/fixing #61897)
This will have merge conflict with #64137 and #64136. Slight preference for merging those first so I only have to rebase one thing instead of 2.