BUG: Fix Behavior Change from #64366 Regarding NaN Handling With Mask#65372
Open
Alvaro-Kothe wants to merge 3 commits into
Open
BUG: Fix Behavior Change from #64366 Regarding NaN Handling With Mask#65372Alvaro-Kothe wants to merge 3 commits into
Alvaro-Kothe wants to merge 3 commits into
Conversation
Alvaro-Kothe
force-pushed
the
fix/revert-nan-mask-verification
branch
from
b80419e to
d6e8b79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointed out by @jbrockmendel in #64848 (comment).
Previously
NaNwas checked only without a mask. After #64366 it's being checked unconditionally. Restore original behavior and adds tests forgroupbyandnanops.Went back in history to check that the tests fails on b935209 and doesn't fail on 027ea1e, with the exception that
nanskewandnankurthave shown the same wrong behavior asnansemregarding returning a scalarnp.nanwhen usingaxisnotNone.