Repository navigation
CI: update pyarrow-nightly pixi env before installing to avoid stale locked wheel - #67059
jorisvandenbossche merged 5 commits into
Conversation
|
This seems to work (the env gets set up here, while on main and in other PRs it is currently failing again as it is the end of the week). |
|
@mroeschke what do you think here? |
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Sure I'm OK with this solution.
(For context, my push a few months ago on pyarrow's abi3 support (apache/arrow#50409) was an attempt to help the wheel expiry issue in the nightly index)
| cache: true | ||
| cache-write: ${{ github.event_name == 'push' && github.ref_name == 'main' }} |
There was a problem hiding this comment.
Could we make these fields (and run-install) dependent on a variant of ${{ inputs.environment != 'pyarrow-nightly' }} to avoid duplicating the prefix-dev/setup-pixi?
There was a problem hiding this comment.
I mentioned it in the comment above, but so I initially tried this but I found it got too complicated:
Small disadvantage of having the setup-pixi action twice (although updating the version pins gets automated anyway), but trying to combine it in one step became a bit unreadable (the
cacheandenvironmentskeys can not be specified for run-install: false)
The cache cannot be set to True (that can still be set to False with a form of if / else expression), and environments should not be set (I didn't try if setting it to an empty string works, as that would also be possible with and if/else expression).
But even if possible, it became quite unreadable IMO
There was a problem hiding this comment.
Ah gotcha (sorry I missed that)
Ah, yes, when that lands and if that causes the wheels to be kept longer, we can consider cleaning this up again. |
2 participants
Based on the suggestion at prefix-dev/pixi#6186 (comment), trying to fix #65690 (comment)