Fix Canvas Images going invisible#717
Merged
Merged
Conversation
We were rendering to canvases and then expecting them to stick around, but love documents canvas being cleared when the window size changes. Instead we should render them to an image and just use the image instead. Added helper methods that make sure to reset the graphics state when rendering Also used the right DPI and filter. Tested stage and character bundles
Endaris
approved these changes
Nov 1, 2025
JamesVanBoxtel
commented
Nov 1, 2025
Contributor
Author
JamesVanBoxtel
left a comment
JamesVanBoxtel
left a comment
There was a problem hiding this comment.
Looks good, tested on love 11 and 12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were rendering to canvases and then expecting them to stick around, but love documents canvas being cleared when the window size changes.
Instead we should render them to an image and just use the image instead.
Added helper methods that make sure to reset the graphics state when rendering
Also used the right DPI and filter.
Tested stage and character bundles