Don't load garbage for bundle characters#719
Merged
Endaris merged 1 commit intoNov 2, 2025
Merged
Conversation
Endaris
added
bug
JamesVanBoxtel
approved these changes
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle characters explicitly don't load up the default character's fallback textures as character select fallback is assembled from bundle mods and ingame assets are never used.
Logically they also should not try to create garbage textures or load up telegraph images.
In the current version forced resizes, e.g. due to smash+C or automatic scale change, caused a crash as the reload explicitly tries to do a full load on the config character (which can be a bundle) and selected characters in ongoing matches (which cannot be a bundle). I think bundles are otherwise never even fully loaded which is why this only occurs in said reload scenarios.