-
Notifications
You must be signed in to change notification settings - Fork 47
fix: support xarray v2025.x #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: updates-2025
Are you sure you want to change the base?
Conversation
- Remove xarray version pin (<2025.3.0) from dependencies - Fix pytest-lazy-fixtures import conflict - Prepare for xarray v2025 breaking changes
- Remove <2025.3.0 pin from minimum-tests.yml and maximum-tests.yml - Allow testing with latest xarray versions
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## updates-2025 #883 +/- ##
===============================================
Coverage ? 91.52%
===============================================
Files ? 59
Lines ? 6266
Branches ? 0
===============================================
Hits ? 5735
Misses ? 531
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Coordinate ordering changed in xarray v2025 - Updated expected outputs in utils.py and classes.py to match new ordering
for more information, see https://pre-commit.ci
- PerfectModelEnsemble.verify: fix coordinate ordering (skill before lead) - PerfectModelEnsemble.bootstrap: update data values for new random state
- Add explicit np.random.seed(42) for reproducibility (attempt)
b7d0b9b to
9cc0f1e
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
…to fix-xarray-v2025
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
#884 may fix src/climpred/tests/test_bootstrap.py::test_bootstrap_PM_lazy_result in py3.12 https://github.com/pangeo-data/climpred/actions/runs/21221428782/job/61056950903?pr=883 |
|
how about deprecating all below python 3.11 the same way as Xarray? |
If you think that's fine, we could do that both here and in |
Summary
This PR removes xarray version pins to support v2025.x releases and fixes related compatibility issues.
Closes #880
Changes Made
Dependencies
Test Infrastructure
Analysis
Breaking changes in xarray v2025.x:
Testing
References