19.0 is red on UI checks since #190 (run 35579519666); the commit before it was green. Every PR branched from it inherits the failure.
Four assertions fail:
- the record pane cannot be folded away
- at 1280px there is no button to open the record from
- at 1280px the top bar has no button for the mailbox list
- a phone has no button for the mailbox list
Cause. The toggle's class is built from the pane key --
o_mailpro_pane_toggle_{{pane}} in static/src/xml/conversation_view.xml:54 --
and #190 renamed the keys to mailbox_list, conversation_list,
conversation, odoo_record. tools/ui_check.py still queries the retired
keys, so every lookup returns None and the checks report a missing button.
The screen itself is fine; the browser check is looking for classes that no
longer exist.
Fix. In tools/ui_check.py (lines 714, 738, 750, 762, 935, 936, 938, 1064,
1095, 1112, 1132, 1144, 1145):
.o_mailpro_pane_toggle_rail -> .o_mailpro_pane_toggle_mailbox_list.o_mailpro_pane_toggle_list -> .o_mailpro_pane_toggle_conversation_list.o_mailpro_pane_toggle_record -> .o_mailpro_pane_toggle_odoo_record
Longest name first if it is done with sed, or _list rewrites the other two.
Leave .o_mailpro_odoo_record_button and .o_mailpro_split_toggle alone --
those assert an absence and are already correct.
Why nothing caught it. tests/test_inbox_panes.py was added by #190 to hold
the four names together, and it reads use_panes.js, the template and
ARCHITECTURE.md -- not ui_check.py. A pane name is five strings, not four.
Adding the browser check to that test is what keeps the next rename from
costing a red default branch.
19.0is red on UI checks since #190 (run 35579519666); the commit before it was green. Every PR branched from it inherits the failure.Four assertions fail:
Cause. The toggle's class is built from the pane key --
o_mailpro_pane_toggle_{{pane}}instatic/src/xml/conversation_view.xml:54--and #190 renamed the keys to
mailbox_list,conversation_list,conversation,odoo_record.tools/ui_check.pystill queries the retiredkeys, so every lookup returns
Noneand the checks report a missing button.The screen itself is fine; the browser check is looking for classes that no
longer exist.
Fix. In
tools/ui_check.py(lines 714, 738, 750, 762, 935, 936, 938, 1064,1095, 1112, 1132, 1144, 1145):
.o_mailpro_pane_toggle_rail->.o_mailpro_pane_toggle_mailbox_list.o_mailpro_pane_toggle_list->.o_mailpro_pane_toggle_conversation_list.o_mailpro_pane_toggle_record->.o_mailpro_pane_toggle_odoo_recordLongest name first if it is done with sed, or
_listrewrites the other two.Leave
.o_mailpro_odoo_record_buttonand.o_mailpro_split_togglealone --those assert an absence and are already correct.
Why nothing caught it.
tests/test_inbox_panes.pywas added by #190 to holdthe four names together, and it reads
use_panes.js, the template andARCHITECTURE.md -- not
ui_check.py. A pane name is five strings, not four.Adding the browser check to that test is what keeps the next rename from
costing a red default branch.