Paper texture 2.0 - #220
Open
uuuulala wants to merge 190 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
There are 6 total unresolved issues (including 5 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 127f8e3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
High Risk
Breaking public API and visual output for
PaperTextureconsumers; large shader change needs regression on image filter paths and presets. The unreferencedpaper-texture---.tsscratch file should be confirmed intentional or removed before merge.Overview
Paper Texture 2.0 replaces the previous paper effect with a new shader, public API, presets, and docs controls.
The color model moves from
colorFront/colorBack+contrasttocolorBack,colorPaper, andcolorShadow, with image controlsblending,distortion, andclip. Surface detail params change:crumpleCount(capped via exportedpaperTextureMeta.maxCrumpleCount),wrinkles/wrinkleSize,roughnessSize/roughnessRows, directionalanglelighting, and per-axis foldsfoldSizeX/YandfoldOffsetX/Y. Removed uniforms includefade,crumpleSize, andfoldCount.The fragment shader is rewritten around relief lighting, new crumple/wrinkle/fold math, and updated image compositing (
u_isImage). ReactPaperTexturemaps the new props; deprecated aliases shrink tofoldsNumber→crumpleCount(andfiberScale). Presets are now Default, Spread, Creased, and Flat (replacing Abstract, Cardboard, Details).Docs Leva panel and
paperTextureDefmirror the new parameter set.Reviewed by Cursor Bugbot for commit 55a3ef1. Bugbot is set up for automated code reviews on this repo. Configure here.