Repository navigation
fix: Sign upstream rebase commits - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the three bot signing secrets required by the upstream rebase workflow introduced in paradedb/actions#34, retaining the existing
@v14reference.The rebase preserves original authors, signs recreated commits with the bot's SSH key, and continues using the GitHub App for pushes. Coordinate merging this change with moving
v14to the signing-enabled Actionsmain: the current tag does not yet declare these secrets.Validation: actionlint and
git diff --checkpassed. The shared workflow's local integration test verified signed rebases, author/content preservation, and failure when the signing key is missing. Production sync was not run.