fix: #477 Add defensive error handling for malformed LLM response choices#667
Merged
Merged
Conversation
Contributor
Author
|
@param20h , this pr is under gssoc 2026, kindly review it |
param20h
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR Checklist
🔗 Related Issue
Closes #477
📝 What does this PR do?
Adds defensive attribute retrieval using
getattrwhen parsing the LLM client's chat completion choices. Previously, the logic assumed that ifresponse.choiceswas populated, the nested.messageand.contentattributes were guaranteed to exist, causing an unhandledAttributeErroron unexpected schemas or partial API responses. This fix ensures the application safely falls back to returningNonewithout crashing.🗂️ Type of Change
🧪 How was this tested?
📸 Screenshots (if UI change)
N/A - Backend logic fix only.
No major concerns. The change is isolated strictly inside
generate_document_summaryand builds upon the existing default return patterns.✅ Self-Review Checklist
dev, notmainmainbranch or any HuggingFace deployment config