fix: return overall health status in health endpoint#671
Merged
param20h merged 1 commit intoJun 23, 2026
Conversation
param20h
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR Checklist
🔗 Related Issue
Closes #630
📝 What does this PR do?
Fixes an issue where the
/healthendpoint exposed the database health status as the top-levelstatusfield instead of the computed overall system health status.Previously, when ChromaDB became unavailable while the database remained healthy, the endpoint incorrectly reported the application as healthy, causing monitoring systems to misinterpret the application's actual state.
This PR:
🗂️ Type of Change
🧪 How was this tested?
uvicorn app.main:app --reload)npm run devinsidefrontend/)Additional verification:
Added regression tests for:
Verified tests fail on the previous implementation and pass with the fix.
Ran targeted API tests.
Ran the full backend test suite.
Test Results:
Passed: 5 tests
Passed: 236 tests
📸 Screenshots (if UI change)
N/A (Backend-only bug fix)
This is a focused fix for Issue #630.
The change is limited to health status reporting and regression tests. No unrelated functionality, API endpoints, database schema, or application behavior was modified.
✅ Self-Review Checklist
dev, notmainmainbranch or any HuggingFace deployment config