Skip to content

3 fixes #662 #663 #664 | assigned by param20ha#679

Merged
param20h merged 1 commit into
param20h:devfrom
vastavikadi:dev
Jun 24, 2026
Merged

3 fixes #662 #663 #664 | assigned by param20ha#679
param20h merged 1 commit into
param20h:devfrom
vastavikadi:dev

Conversation

@vastavikadi

Copy link
Copy Markdown
Contributor

📋 PR Checklist

Thank you for contributing to PDF-Assistant-RAG! 🎉
Please fill out this template before submitting. PRs without it filled in will be closed.


🔗 Related Issue

Closes #662 #663 #664

📝 What does this PR do?

  • Added validate_production() method that was called in main.py lifespan but didn't exist
  • Changed EncryptedString._get_cipher() from SECRET_KEYFIELD_ENCRYPTION_KEY
  • Permanent failures (corrupt PDFs, validation errors) are no longer retried
  • Added pool_recycle=3600 to PostgreSQL engine to prevent stale connections
  • Queries exceeding configurable threshold (default 1s) are logged as warnings
  • New SecurityHeadersMiddleware adds to every API response
  • Graceful Shutdown
  • Input Validation Hardening
  • Nginx Security Headers
  • Audit Logging

🗂️ Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🔧 Refactor / code cleanup
  • 📝 Documentation update
  • 🎨 UI / styling change
  • ⚙️ CI / tooling / config change
  • 🧪 Tests

🧪 How was this tested?

  • Ran the backend locally (uvicorn app.main:app --reload)
  • Ran the frontend locally (npm run dev inside frontend/)
  • Tested the affected API endpoints manually
  • Added / updated tests

📸 Screenshots (if UI change)


⚠️ Anything to flag for reviewers?


✅ Self-Review Checklist

  • My branch is based on dev, not main
  • I have not added any secrets / API keys
  • I have not modified main branch or any HuggingFace deployment config
  • My code follows the existing style (no unnecessary formatting changes)
  • I have updated relevant docs / comments if needed

@vastavikadi vastavikadi requested a review from param20h as a code owner June 23, 2026 20:11
@vastavikadi

Copy link
Copy Markdown
Contributor Author

@param20h please review the changes

@vastavikadi vastavikadi reopened this Jun 24, 2026
@param20h param20h merged commit 964ddf1 into param20h:dev Jun 24, 2026
16 checks passed
@github-actions github-actions Bot added bug Something isn't working enhancement New feature or improvement gssoc GirlScript Summer of Code 2026 issue/PR gssoc:approved Approved for GSSoC base points (+50 pts) mentor:param20h Mentor for this PR labels Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or improvement gssoc:approved Approved for GSSoC base points (+50 pts) gssoc GirlScript Summer of Code 2026 issue/PR mentor:param20h Mentor for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]

2 participants