Rebuild the committed platform dist after PT-4304 - #9
Merged
Merged
Conversation
`packages/*/dist` is committed so paranext-core can stage the editor by copying it, with no pnpm or nx on the consumer side. PT-4304's branch predated that convention, so merging it moved `src/` while `dist/` stayed at the previous build: the committed declarations carry no `VerseLayout` and no `"block-verse"` view, and the committed bundle carries none of the code behind them. Regenerated with `node scripts/rebuild-committed-output.mjs`. `etc/*.api.md` was already current, so only `dist/` moves. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JsciPEjXb7X4DZzahoWPwo
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripture-editors'mainis red, and the reason matters beyond CI: the editorparanext-core is staging right now does not contain PT-4304.
What happened
packages/*/distis committed so paranext-core can stage the editor by copying it — no pnpm,no nx, nothing on the consumer side. That convention landed in #1.
#538 (PT-4304, block-verse view) was
branched before that and merged 26 minutes after it. Its merge moved
src/;dist/stayed at thebuild #1 committed. So on
maintoday:VerseLayout/"block-verse"packages/platform/srcpackages/platform/dist/index.d.ts(committed)git log -1 -- packages/platform/diststill points at #1's merge commit.The
Check the committed build output is currentstep is exactly the guard for this, and it iswhat is failing on
main— and, inherited, on every open PR.Why it is not only a CI problem
platform-yalcismain+ one commit, so it carries the same staledist/, and core's stagingcopies it verbatim. Core's builds are green because a stale build is still a valid build — just
one release behind its own source. Nothing else would have caught that.
The change
node scripts/rebuild-committed-output.mjs, committed.etc/*.api.mdwas already current, so onlydist/moves — the api report went in with #538, the bundle did not.Verified locally with
node scripts/verify-committed-dist.mjs(Committed build output is current. ✓).After this merges
Run
npm run move-platform-yalcso consumers pick the rebuiltdist/up. The editor'sdependenciesandpeerDependenciesdo not change here, so paranext-core needs no lockfilerefresh and
verify-platform-yalc.ymlwill pass.Worth a follow-up
Any older branch merged into
mainfrom here on has the same shape: itssrc/wins the merge andits
dist/is whatever the branch point had. CI catches it after the merge, on a redmain,rather than on the PR. #5 — giving the
published artifacts their own directory no nx task owns — is the structural fix.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
🤖 Generated with Claude Code
https://claude.ai/code/session_01JsciPEjXb7X4DZzahoWPwo
This change is