fatxpool: added mortal transactions integration test #8887
Conversation
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
| @@ -0,0 +1,9 @@ | |||
| title: '`fatxpool`: added mortal transactions integration test ' | |||
There was a problem hiding this comment.
TODO: a prdoc shouldn't be needed by this PR which adds just tests. However, even I pick the label for no crates should be published, check semver still fails by detecting changes in the crate (which is true, but the changes are only in tests, and they shouldn't count for crate bumps). Not sure if I am supposed to do something else, to check with release team.
There was a problem hiding this comment.
Removed the prdoc, will leave checksemver failing - at the same time it must ignore changes in tests if possible, must debug why it does.
There was a problem hiding this comment.
Not sure about this. We changed the code, PRdoc won't hurt us after all.
There was a problem hiding this comment.
We changed the tests, checksemver implies a version bump should be done. The problem I have with this is that I am required to add a prdoc for non-user facing stuff, with an associated bump.
Co-authored-by: Sebastian Kunert <mail@skunert.dev>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
| // so we get 3750KB. In the test scenario we aim for 5 txs per block roughly (not precesily) | ||
| // so to fill a block each user tx must have around 750kb. | ||
| #[tokio::test(flavor = "multi_thread")] | ||
| #[ignore] |
There was a problem hiding this comment.
If this is quick test, maybe we should remove ignore?
Could also be applied for other quick e2e tests..
There was a problem hiding this comment.
It makes even more sense now when the pool is no longer actively maintained. I used to run all of these tests regularly so I knew all is good.
Now, nobody checks them, and maybe other components may cause regression in pool.
There was a problem hiding this comment.
I think they won't work either way because of the error bellow. I think we have already some zn-sdk tests that use such binaries, but I remember they were included in a certain dedicated zn job, which might do the necessary setup. Maybe @lrubasze knows more about what's needed from a CI perspective to run zn-sdk tests that depend on certain binaries?
thread 'send_lower_priority_mortal_txs' panicked at substrate/client/transaction-pool/tests/integration.rs:222:10:
called `Result::unwrap()` on an `Err` value: NetworkInit(Invalid network config to use provider native: Invalid configuration:
Missing binary polkadot, compile by running (in the polkadot-sdk repo):
cargo build --locked --release --features fast-runtime --bin polkadot --bin polkadot-prepare-worker --bin polkadot-execute-worker
There was a problem hiding this comment.
I created #10348. I plan to tackle it separately from this PR. For now I would keep the #ignore attribute for the added tests just because I don't plan to investigate on this PR what's required to have e2e tests runnable in the CI (e.g. the main issue being binaries access for the current tests, for others I am not sure), or invest time in setting up other environments for longer running e2e tests. For #10348 maybe it is worth chatting more with @pepoviola - again, not part of the current PR scope. I'll follow up specifically when I'll have bandwidth.
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
38c598e
Description
Based on michalkucharczyk/tx-test-tool#43.
Integration
N/A
Review Notes