Modify TouchEvent listener from TouchStart to TouchMove - #56
Open
pk1057 wants to merge 27 commits into
Open
Conversation
…ms drag and drop problems
Head up to upstream
Version 1.3.2
Fixes issues with e.g. Firefox on Linux and JxBrowser, which do not constantly send dragOver events
* Introduced DragGrabFilter that can filter inner components of a container from "grabbing" on client-side. It enables us to disable dragging container by grabbing its innner components, e.g. we can prevent dragging of VerticalLayout if a user grabs inner Table. * Implemented DragCaptionProvider that can be used to show simple DOM element with icon and caption instead of copy of dragged component. DragCaptionProvider must return DragCaption POJO for each draggable component inside of a container.
merge new features
Remove vaadin7 support
update 8.1.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TouchEvent Listener creates problems on IDevices because it thought even on single touch that we wanna move the component, but instead we just tried to open the context menu.
When we change the eventtype everything works as expected