Skip to content

Make the skill trigger reliably: broader description, dependency-detection hook, doc fixes - #111

Merged
jcgueriaud1 merged 3 commits into
masterfrom
broaden-skill-trigger
Jul 7, 2026
Merged

Make the skill trigger reliably: broader description, dependency-detection hook, doc fixes#111
jcgueriaud1 merged 3 commits into
masterfrom
broaden-skill-trigger

Conversation

@jcgueriaud1

@jcgueriaud1 jcgueriaud1 commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Three related changes to make the vaadin-playwright-test skill fire and behave correctly:

  1. Broaden the skill trigger description so it also matches indirect requests — GitHub issues, PRs, specs, "fix the failing test" — not just direct mentions of DramaFinder/Playwright.

  2. Add deterministic trigger signals for tasks that never mention Vaadin/tests at all. Description matching is a heuristic over context; if nothing in the prompt or read files hints at testing, no wording helps. So:

    • a SessionStart plugin hook greps pom.xml for the dramafinder artifact and, on a hit, injects a standing reminder to use the skill for any IT test work;
    • the setup runbook now appends an equivalent pointer to the consuming project's CLAUDE.md, covering sessions where the plugin hook isn't active.
    • plugin version bumped to 0.3.0.
  3. Fix documentation inaccuracies found in review:

    • element-mapping.md: the Key Methods column listed many methods that don't exist (selectByText, clickRow, sortByColumn, assertUnchecked, sendMessage, uploadFile, wrong get(page) factories on Dialog/Details/Card/MenuBar/…). Every entry is now verified against the auto-generated api-reference.md.
    • SKILL.md: fixed wrong wrapper calls in the raw-locator guidance, restored the formatter-mangled Java example blocks, documented the MainView/Main → root route mapping, added a version-drift caveat for the bundled API reference, and made Steps 4–5 write/run without confirmation during autonomous execution so the broadened trigger doesn't stall unattended agents.
    • setup.md: cleaned up malformed XML snippets.
    • TESTING.md: page objects described by library package instead of a source path that only exists inside this repo.

Test plan

  • Hook emits the reminder in a project whose pom declares the dramafinder artifact; silent (exit 0) elsewhere
  • Install the plugin from the marketplace and confirm the SessionStart hook runs
  • CI's api-reference index check still passes

🤖 Generated with Claude Code

jcgueriaud1 and others added 3 commits July 7, 2026 15:40
The skill matcher keys off signals present in the conversation. When a
requirement lives inside a fetched issue/PR/spec body (e.g. "Implement
#85.") rather than the user's own words, none of the old trigger
keywords appear in the prompt and the skill never fires.

Widen the description to trigger on indirect requests, on in-context
code signals (SpringPlaywrightIT, @PlaywrightElement, IT file paths),
and any Vaadin-project task involving a Playwright/IT test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…steps

- element-mapping.md: verify every method in the Key Methods column against
  the auto-generated api-reference.md; replace non-existent APIs
  (selectByText, clickRow, sortByColumn, assertUnchecked, sendMessage,
  uploadFile, wrong get(page) factories) with the real ones
- SKILL.md: fix wrong wrapper calls in the raw-locator guidance, restore the
  formatter-mangled Java templates, document MainView/Main root route
  mapping, add a version-drift caveat for api-reference.md, and make
  Steps 4-5 write/run without confirmation during autonomous execution
- setup.md: clean up malformed XML snippets
- TESTING.md: describe page objects by library package instead of a source
  path that only exists in the DramaFinder repo

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Skill matching is a heuristic over context: a task that never mentions
Vaadin/Playwright/tests gives the model no signal to load the skill. Add two
deterministic signal sources:

- SessionStart plugin hook that greps pom.xml for the dramafinder artifact
  and, on a hit, injects a standing reminder to use the skill for any IT
  test work
- setup.md step that appends an equivalent pointer to the consuming
  project's CLAUDE.md, covering sessions where the plugin hook isn't active

Bump plugin version to 0.3.0 (plugin.json + tile.json).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jcgueriaud1 jcgueriaud1 changed the title Broaden vaadin-playwright-test skill trigger to indirect requests Make the skill trigger reliably: broader description, dependency-detection hook, doc fixes Jul 7, 2026
@jcgueriaud1
jcgueriaud1 merged commit 1a0f2a3 into master Jul 7, 2026
2 checks passed
@jcgueriaud1
jcgueriaud1 deleted the broaden-skill-trigger branch July 7, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant