Add read-only assertions via HasReadOnlyElement mixin (#113) - #117
Merged
Conversation
Introduce a shared HasReadOnlyElement mixin so fields expose
assertReadOnly()/assertNotReadOnly()/isReadOnly() instead of relying on
raw getProperty("readonly") checks.
- TextFieldElement implements the mixin (inherited by PasswordField,
EmailField and TextArea elements).
- ComboBoxElement and MultiSelectComboBoxElement drop their duplicated
read-only methods in favor of the mixin.
- Add a read-only example to TextFieldView and a testReadOnly IT.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.
Problem
Asserting a field's read-only state required a raw property check:
Change
Introduces a shared
HasReadOnlyElementmixin (following the existingHasEnabledElementpattern) so fields expose first-class read-only helpers:isReadOnly(),isReadOnly(boolean)assertReadOnly(),assertReadOnly(boolean),assertNotReadOnly()The issue's example becomes:
Details
TextFieldElementimplements the mixin — inherited automatically byPasswordFieldElement,EmailFieldElement, andTextAreaElement.ComboBoxElementandMultiSelectComboBoxElementhad duplicated read-only methods; they now use the shared mixin (behavior unchanged).TextFieldViewand atestReadOnlyIT.Testing
mvn test-compilepasses.TextFieldViewIT#testReadOnlypasses.ComboBoxViewIT#testReadOnly/MultiSelectComboBoxViewIT#testReadOnlystill pass after the refactor.🤖 Generated with Claude Code