Vaadin update and fixes - #31
Merged
Merged
Conversation
- Bump Vaadin to 25.2.1. This alone resolves the compile incompatibility reported in #28 (older Vaadin only). - #29: guard against a missing .tox-hugerte-aux element when the editor is not inside a Dialog, which threw a TypeError. - #30: setValue() back to a previously-set value after a user edit no longer gets diffed away. Client edits update only the model via the delta handler, so the "value" property mirror goes stale; setPresentationValue now force-pushes to the editor exactly when the value equals that stale mirror (null-safe). - Add SetValueAfterEditView + a deterministic regression test covering both the reset-to-previous and clear-after-edit branches. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- CLAUDE.md: build/test commands and architecture notes for future Claude Code sessions. - .mcp.json: shared Vaadin docs MCP server (public docs endpoint). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #29 and #30