Normalize list marker spacing to avoid accidental code blocks - #66
Merged
Conversation
Under strict CommonMark/GFM, a list marker followed by 5+ spaces turns the rest of the line into an indented code block instead of plain text (e.g. "1. a" renders as a code block). This is an easy mistake to make when padding markers for visual alignment, and the resulting rendering change is silent and confusing. Add PreprocessListMarkers, which always collapses the whitespace after a list marker to a single space before parsing, skipping fenced code blocks. This is an intentional deviation from GitHub's rendering in favor of predictability. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1. a) currently renders as an indented code block instead of a normal list item, per strict CommonMark/GFM rules. This is an easy mistake to make (e.g. padding markers for visual alignment) and the result is a silent, confusing rendering change.PreprocessListMarkers(), which always normalizes the whitespace after a list marker to a single space before parsing, skipping content inside fenced code blocks.Test plan
go build ./...go vet ./...go test ./...TestPreprocessListMarkerscovering ordered/bullet markers, nested lists, fenced code blocks (skipped), indented code blocks (skipped), blockquote-prefixed lists, and thematic-break edge cases1. anow renders as<li>a</li>instead of a<pre><code>block🤖 Generated with Claude Code