Update NEMAD API base URL#65
Conversation
Changed hardcoded URL from https://nemad.org/api to configurable environment variable with https://api.nemad.org/api as default.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe NEMAD_BASE_URL constant in the server configuration was changed from a hard-coded value to dynamically read from an environment variable with a fallback default. This enables runtime configuration of the API endpoint without code modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
User description
The backend API URL has changed. Updated the hardcoded URL from
https://nemad.org/apitohttps://api.nemad.org/api.Also made the URL configurable via
NEMAD_BASE_URLenvironment variable for better flexibility.PR Type
Bug fix, Enhancement
Description
Updated NEMAD API base URL from
https://nemad.org/apitohttps://api.nemad.org/apiMade base URL configurable via
NEMAD_BASE_URLenvironment variableDiagram Walkthrough
File Walkthrough
server.py
Make NEMAD base URL configurableservers/nemad/src/nemad/server.py
NEMAD_BASE_URLwith environment variable lookuphttps://api.nemad.org/apios.getenv()with default valueSummary by CodeRabbit