[fix] grant codesign keychain access to unblock CI signing hang#88
Open
YJack0000 wants to merge 6 commits into
Open
[fix] grant codesign keychain access to unblock CI signing hang#88YJack0000 wants to merge 6 commits into
YJack0000 wants to merge 6 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow hung for 1h+ at
replacing existing signatureduring codesign. The temporary keychain's key partition list was missing thecodesign:partition, so/usr/bin/codesignblocked on a GUI keychain-auth prompt that can never appear on CI.Fix
-T /usr/bin/codesign -T /usr/bin/productsign(instead of-A)codesign:to the key partition list:-S apple-tool:,apple:,codesign: -ssecurity find-identity -v -p codesigningpreflight checkVerified via release run 28372652468 dispatched from this branch.