change some default settings inline with what the golang default http#8
change some default settings inline with what the golang default http#8
Conversation
client settings are hoping to avoid some odd behaviour around idle connections
leonyork
left a comment
There was a problem hiding this comment.
I've not looked into if these are sensible numbers for the new transport settings you're using (apart from the testing you've done elsewhere), but/so I think it's worth making them configurable and setting the current values as the defaults.
| TLSHandshakeTimeout: 10 * time.Second, | ||
| ExpectContinueTimeout: 1 * time.Second, |
There was a problem hiding this comment.
Can we make these configurable as command line arguments (like the others), so that we can tune this without releasing a new version of regproxy?
There was a problem hiding this comment.
I copied and pasted these from the default configuration and possible I shouldn't have...
Both are irrelevant for our use case (test-control doesn't use TLS, nor does it use HTTP 100-continue responses.)
I could make them configurable for the convenience of others who might be using these features but it won't help us.
There was a problem hiding this comment.
Thanks for explaining. Approved.
...client settings are
hoping to avoid some odd behaviour around idle connections