Use local canvas-confetti dependency#9
Open
RohitRajendran wants to merge 1 commit intopatrickmineault:mainfrom
Open
Use local canvas-confetti dependency#9RohitRajendran wants to merge 1 commit intopatrickmineault:mainfrom
RohitRajendran wants to merge 1 commit intopatrickmineault:mainfrom
Conversation
RohitRajendran
force-pushed
the
fix-optional-confetti
branch
from
4c19a7b to
e985765
Compare
RohitRajendran
changed the title
Owner
|
Is this a real issue you ran into or an auto-AI thing? |
Author
|
It was a real issue I ran into a few days ago. Although seems like the CDN is back to working now so it's no longer an issue but the PR would still help avoid issues in the future. You can see it happen for yourself if ya block the network request for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app was crashing because the cdn used for the confetti library is no longer available.
Switches confetti to the local canvas-confetti dependency instead of loading from the CDN