Code improvements #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of May 2017, successful submissions to stathat do not return a body: https://blog.stathat.com/2017/05/05/bandwidth.html This changes the code and tests to accommodate this new behavior. - the success code is now 200, not 204, so all 200s are considered successful - because there is no body, we no longer check for resp.msg == "ok" - oddly, failures return a "status: 500" in their body, but still have a 200 success code. I don't know if this is desired behavior or a bug, and I don't know how long this has been the case. i have written to StatHat support about it. so, we still parse for a code in the body and let it take precedent
- consistent use of {} for one-line blocks
- use do..end for more complicated block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: this is based on #8, so that should be merged first. Then this can be rebased and look tidier.
Various code improvements, some more opinionated than others. Look at individual commits.
Because it's removing support for ruby < 2, version, the major version will need to be bumped. since ruby 2.3 will be EOL soon, support 2+ seems quite reasonable.
Let me know if you dislike any particular changes, I can remove those.
let me know what you think!