Skip to content

bug fix: circular issue on close #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trillobite wants to merge 1 commit into
base: development
Choose a base branch
from
Open

bug fix: circular issue on close #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions app/common/tmDetailFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,21 +182,38 @@ function BaseDetail(
return deferred.promise;
};

this.stateCache = "";
// $state.stateCache = "";

this.close = function () {
var self = this;
// var self = this;
this.canILeave().then(function (canILeave) {

if (canILeave) {
let backState = self.$state.back.fromState.name;
self.docSvc.clearDocument();

let goListView = () => {
// we are going back to the list so clear out the $state.data for next circular issue
$state.data = null;
self.$state.go(self.constructorArgs.listView);
}

let goBack = () => {
$state.stateCache = self.$state.current.name;
self.$state.go(backState, $state.back.fromParams);
}

// !($state.data === backState) handle circlular issue with back button
// the back state and the to state are the same
if (backState && backState != "" && !($state.data === backState)) {
self.$state.go(backState, $state.back.fromParams);
if(backState == $state.stateCache) {
goListView();
} else {
goBack();
}
} else {
// we are going back to the list so clear out the $state.data for next circular issue
$state.data = null;
self.$state.go(self.constructorArgs.listView);
goListView();
}
}
});
Expand Down