Skip to content

feat(table): [PF-3917] document tokens in all themes/modes #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 1 commit into from
May 5, 2026
Merged

feat(table): [PF-3917] document tokens in all themes/modes #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:18 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

@mixin pf-v6-tokens {
--pf-t--global--background--color--action--plain--default: rgba(0, 0, 0, 0.0000);
Expand Down
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-default.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:18 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

@mixin pf-v6-tokens {
--pf-t--global--background--color--500: rgba(21, 21, 21, 0.4000);
Expand Down
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-felt-dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:19 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

// Only tokens that differ from base theme (14 tokens)
@mixin pf-v6-tokens {
Expand Down
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-felt-glass-dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:19 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

// Only tokens that differ from base theme (33 tokens)
@mixin pf-v6-tokens {
Expand Down
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-felt-glass.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:19 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

// Only tokens that differ from base theme (23 tokens)
@mixin pf-v6-tokens {
Expand Down
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-felt-highcontrast-dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:19 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

// Only tokens that differ from base theme (43 tokens)
@mixin pf-v6-tokens {
Expand Down
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-felt.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:19 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

// Only tokens that differ from base theme (8 tokens)
@mixin pf-v6-tokens {
Expand Down
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-glass-dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:19 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

// Only tokens that differ from base theme (19 tokens)
@mixin pf-v6-tokens {
Expand Down
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-glass.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:19 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

// Only tokens that differ from base theme (15 tokens)
@mixin pf-v6-tokens {
Expand Down
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-palette.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:18 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

@mixin pf-v6-tokens {
--pf-t--color--black: #000000;
Expand Down
2 changes: 1 addition & 1 deletion packages/module/build/css/tokens-redhat-highcontrast.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// Do not edit directly
// Generated on Thu, 30 Apr 2026 21:31:19 GMT
// Generated on Mon, 04 May 2026 19:53:21 GMT

@mixin pf-v6-tokens {
--pf-t--global--background--color--500: rgba(21, 21, 21, 0.4000);
Expand Down
178 changes: 178 additions & 0 deletions packages/module/patternfly-docs/content/tokensTable.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,175 @@
/* Keep column widths stable when Value cell content changes (theme switch, all vs one theme) */
.tokens-table-fixed-layout {
table-layout: fixed;
width: 100%;
}

.tokens-table-fixed-layout td {
vertical-align: middle;
}

.tokens-table-fixed-layout td:not(.tokens-table-value-cell) {
overflow-wrap: anywhere;
word-break: break-word;
}

/* Value column: one line per theme row; scroll horizontally if needed */
.tokens-table-fixed-layout td.tokens-table-value-cell {
overflow-x: auto;
overflow-y: hidden;
white-space: nowrap;
overflow-wrap: normal;
word-break: normal;
/**
* max-width: 0 is a CSS trick that works with table-layout: fixed.
* It forces the cell to respect percentage widths from <Th width={N}> and enables horizontal scrolling
* when content exceeds the allocated width, instead of expanding the table.
*/
max-width: 0;
}

.tokens-table-value-stack {
min-width: 0;
}

.ws-token-value-line {
display: block;
min-width: min-content;
}

.ws-token-value-line-inner {
flex-wrap: nowrap !important;
width: max-content;
max-width: none;
}

.ws-theme-label-inline {
flex: 0 0 auto;
}

.ws-theme-label-inline .ws-theme-display-label {
white-space: pre;
}

.ws-token-value-main {
flex: 1 1 auto;
min-width: 0;
}

.ws-token-value-main--separated {
margin-inline-start: var(--pf-t--global--spacer--md);
padding-inline-start: var(--pf-t--global--spacer--md);
border-inline-start: var(--pf-t--global--border--width--regular) solid
var(--pf-t--global--border--color--default);
}

.ws-token-value-hex-wrap {
flex: 0 1 auto;
min-width: 0;
}

.ws-token-value-hex {
display: inline-block;
white-space: nowrap;
font-family: var(--pf-t--global--font--family--mono), ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
}

.ws-token-swatch-wrap {
flex: 0 0 auto;
}

.ws-token-value-plain-inline {
flex: 1 1 auto;
min-width: 0;
white-space: nowrap;
}

.ws-token-value-popover-trigger {

@nicolethoen nicolethoen Apr 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the popover triggers shouldn't need so much custom CSS for formatting if they are using plain Buttons

text-decoration: underline dotted;
text-decoration-color: var(--pf-t--global--border--color--default);
text-underline-offset: 0.12em;
}

.ws-token-value-popover-trigger:hover {
text-decoration-color: var(--pf-t--global--border--color--clicked);
}

.ws-token-derivation-popover__theme {
margin-block-end: var(--pf-t--global--spacer--md);
padding-block-end: var(--pf-t--global--spacer--sm);
border-block-end: var(--pf-t--global--border--width--regular) solid
var(--pf-t--global--border--color--default);
}

.ws-token-chain-item {
font-family: var(--pf-t--global--font--family--mono), ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
}

.ws-token-chain-value {
font-family: var(--pf-t--global--font--family--mono), ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
}

.ws-token-chain-value .pf-v6-c-button.pf-m-link.pf-m-inline {
text-decoration: underline;
text-decoration-style: dotted;
text-underline-offset: 0.15em;
}

.ws-token-chain-value .pf-v6-c-button.pf-m-link.pf-m-inline:hover {
text-decoration-style: solid;
}

.ws-token-chain-button {
font-family: inherit;
font-size: inherit;
padding: 0;
vertical-align: baseline;
}

.ws-theme-group-label {
font-size: var(--pf-t--global--font--size--body--sm, 0.875rem);
font-weight: var(--pf-t--global--font--weight--body--default);
color: var(--pf-t--global--text--color--subtle);
cursor: help;
border-radius: var(--pf-t--global--border--radius--small);
padding-inline: var(--pf-t--global--spacer--xs);
background-color: var(--pf-t--global--background--color--secondary--default);
display: inline-block;
}

.ws-theme-group-label:hover {
color: var(--pf-t--global--text--color--subtle);
background-color: var(--pf-t--global--background--color--secondary--default);
}

.ws-theme-group-label:focus-visible {
outline: 2px solid var(--pf-t--global--border--color--clicked);
outline-offset: 2px;
}

.ws-theme-display-label {
font-family: var(--pf-t--global--font--family--mono), ui-monospace, SFMono-Regular, Menlo, Consolas, monospace;
font-size: var(--pf-t--global--font--size--body--sm, 0.875rem);
line-height: var(--pf-t--global--font--line-height--body--sm, 1.4);
white-space: pre;
}

.ws-theme-abbr-trigger {
cursor: help;
border-radius: var(--pf-t--global--border--radius--small);
display: inline;
padding: 0;
}

.ws-theme-abbr-trigger:hover {
background-color: transparent;
}

.ws-theme-abbr-trigger:focus-visible {
outline: 2px solid var(--pf-t--global--border--color--clicked);
outline-offset: 2px;
}

.ws-token-swatch {
height: 1em;
display: inline-block;
Expand All @@ -7,6 +179,12 @@
box-shadow: var(--pf-t--global--box-shadow--sm);
}

.ws-tokens-title-theme {
font-size: 0.65em;
font-weight: var(--pf-t--global--font--weight--body--default);
color: var(--pf-t--global--text--color--subtle);
}

@media (min-width: 1200px) {
.tokens-table-outer-wrapper {
/* Allow table to break out of artificial max-width, fill available space */
Expand Down
Loading
Loading