fix: fixes token JSON path, HC SCSS vars#152
Merged
Merged
Conversation
This was referenced May 15, 2026
kmcfaul
approved these changes
May 15, 2026
|
🎉 This PR is included in version 1.16.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like at some point we changed the directory structure of where default and felt tokens were stored, probably when felt was introduced. However there were some high contrast config files that didn't reference the new structure so they were parsing old JSON data from figma every time we parsed the JSON and created SCSS tokens.
Updated that path and regenerated tokens - a LOT of HC vars were updated. These changes are in a core PR right now - patternfly/patternfly#8407.
Everything looks as expected - this update corrected a bunch of HC styles since perviously the HC SCSS vars were based off of old JSON from figma.