Skip to content

Make a conversion to string without exception #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Taritsyn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make a conversion to string without exception #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Jurassic/Core/TypeConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ internal static string ToString(object value, string defaultValue)
throw new JavaScriptException(ErrorType.TypeError, "Cannot convert a Symbol value to a string.");
if (value is ObjectInstance)
return ToString(ToPrimitive(value, PrimitiveTypeHint.String));
throw new ArgumentException(string.Format("Cannot convert object of type '{0}' to a string.", value.GetType()), nameof(value));
return value.ToString();
}

/// <summary>
Expand Down