Skip to content

fix(nvim,ci): resolve format-on-save conflict, harden CI checks, remove CopilotChat#95

Merged
paveg merged 4 commits intomainfrom
fix/nvim-and-ci-improvements
Mar 25, 2026
Merged

fix(nvim,ci): resolve format-on-save conflict, harden CI checks, remove CopilotChat#95
paveg merged 4 commits intomainfrom
fix/nvim-and-ci-improvements

Conversation

@paveg
Copy link
Copy Markdown
Owner

@paveg paveg commented Mar 25, 2026

Summary

  • Fix format-on-save double execution: Remove LSP autocmd that conflicted with conform.nvim's format_on_save, which already handles formatting with lsp_fallback = true
  • Harden CI format checks: shfmt and stylua checks now fail the job on violations instead of only emitting ::warning:: annotations
  • Improve Neovim CI test: Install latest stable Neovim (instead of apt's outdated version), add Lazy! sync step to verify plugin config health
  • Remove CopilotChat: Delete CopilotC-Nvim/CopilotChat.nvim plugin (replaced by Claude Code); keep zbirenbaum/copilot.lua for inline completion

Test plan

  • just test passes locally
  • CI format job fails when format violations exist
  • CI neovim job runs Lazy! sync successfully
  • Neovim format-on-save fires only once (via conform.nvim)
  • Copilot inline suggestions still work in Neovim

🤖 Generated with Claude Code

paveg and others added 4 commits March 25, 2026 22:53
…ve CopilotChat

- Remove duplicate format-on-save from LSP autocmd; conform.nvim handles it
- Make CI format checks (shfmt, stylua) fail on violations instead of just warning
- Install latest stable Neovim in CI and add Lazy sync plugin health test
- Remove CopilotChat plugin (replaced by Claude Code), keep inline completion

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Collapse consecutive blank lines (cat -s) after removing template syntax
- Use explicit -ln bash for shfmt since zsh features cause parse warnings
- Fix redirect spacing in dot_zshenv.tmpl to match shfmt style

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shfmt does not support zsh syntax (parameter expansion flags, etc.).
Zsh syntax checking is already handled by `zsh -n` in the lint job.
Restrict shfmt to install.sh and .chezmoiscripts/*.sh only.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@paveg paveg merged commit d736f6a into main Mar 25, 2026
10 checks passed
@paveg paveg deleted the fix/nvim-and-ci-improvements branch March 25, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant