iot feedback

lib/api/pet-snapshots-api.js

@@ -1,4 +1,5 @@
 const superagent = require('superagent');
+// Pull the common host/api into own module or env variable
 const url = 'https://pawsio.herokuapp.com/api/pet-snapshots';
 
 module.exports = {

lib/api/pets-api.js

@@ -5,7 +5,7 @@ module.exports = {
     getAll(token) {
         return superagent.get(`${url}/all`)
                 .set('authorization', `Bearer ${token}`)
-                .then(res => res.body)
+                .then(res => res.body) // what happen to semicolons???
     },
     getOne(token, id) {
         return superagent.get(`${url}/${id}`)

lib/get-data.js

@@ -4,6 +4,8 @@ const thermometer = require('./thermometer')();
 const accelerometer = require('./accelerometer')();
 const microphone = require('./microphone')();
 
+// I don't think I would have used the factory function pattern for 
+// the modules in this project. Just seems like extra work.
 module.exports = function getData() {
     return function getData() {
         return Promise.all([

lib/lcd.js

@@ -8,8 +8,8 @@ module.exports = function initiateLCD() {
     // myLcd.write('Hello from PawsIO!');
 
     return function displayMessage(x, y, message) {
-            // TODO: study repo on way to make the message loop across the screen
-            myLcd.setCursor(x, y);
-            myLcd.write(message);
-        };
+        // TODO: study repo on way to make the message loop across the screen
+        myLcd.setCursor(x, y);
+        myLcd.write(message);
+    };
 };

main.js

@@ -43,6 +43,8 @@ function main() {
     // if rotary is negative but have payload, check later whether we push
     let rotarCurr = rotary();
     console.log(rotarCurr);
+
+    // split the logic into functions and make the conditional workflow obvious
     if(rotarCurr < 0) {
         // if you have data to send, send it and then empty array
         if(dataPayload.length && !uploading) {
@@ -58,7 +60,7 @@ function main() {
                         throw { message: 'no internet connection' };   
                     };
                 })
-                .then(res => {
+                .then(() => {
                     dataPayload = [];
                     uploading = false;
                     lcd(1,0,'upload success');