Skip to content

Release: Vault Depreciation#227

Merged
0xRowdy merged 8 commits into
mainfrom
staging
Aug 14, 2025
Merged

Release: Vault Depreciation#227
0xRowdy merged 8 commits into
mainfrom
staging

Conversation

@0xRowdy

@0xRowdy 0xRowdy commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Rowdy and others added 4 commits July 21, 2025 11:59
slippage was to low for ssETH and unable to be solved. updated to 50 bips per jamie and juns requests
fix(ssETH): update withdrawal slippage to 50 bips
@vercel

vercel Bot commented Aug 13, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
nucleus-app Ready Preview Comment Aug 14, 2025 1:54am

Rowdy added 4 commits August 13, 2025 12:11
updated config to remove bridge tab
updated networks config for bobaETH to only allow withdrawal to weth
@0xRowdy 0xRowdy changed the title Release: ssETH bips Release: Vault Depreciation Aug 14, 2025
@JCaraballo113 JCaraballo113 requested a review from Copilot August 14, 2025 02:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements vault depreciation by reordering and reorganizing token configurations to deprecate certain vaults and introduce new tokens. The changes maintain alphabetical ordering in the token configurations and clean up network asset configurations by removing deprecated vault entries.

  • Alphabetical reordering of token configurations in tokensConfig while adding new tokens (TUSD, USDC)
  • Removal of deprecated vault configurations from network assets and bridge settings
  • Addition of new token icon components for TUSD, USDC, and Rswell with proper imports

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
types/TokenKey.ts Adds new token keys TUSD and USDC to the enum
config/tokens.ts Alphabetically reorders all token configurations and adds new token entries
config/networks.ts Removes deprecated vault configurations and bridge settings
components/shared/icons/TokenUsdc.tsx Adds new USDC token icon component
components/shared/icons/TokenTusd.tsx Adds new TUSD token icon component
components/shared/icons/Rswell.tsx Adds new Rswell icon component
components/config/tokenIcons.tsx Updates token icon mappings and imports for new tokens

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread config/tokens.ts
name: 'pufETH',
symbol: 'PUFETH',
[TokenKey.RARI]: {
key: TokenKey.RARIETH,

Copilot AI Aug 14, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RARI token configuration is using TokenKey.RARIETH as the key instead of TokenKey.RARI. This creates a mismatch between the object key ([TokenKey.RARI]) and the internal key property.

Suggested change
key: TokenKey.RARIETH,
key: TokenKey.RARI,

Copilot uses AI. Check for mistakes.
@0xRowdy 0xRowdy merged commit 2ad87cf into main Aug 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants