Reduce template overhead of match #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tuples with the same dimensions now share a single instantiation, regardless of the types held by the SumTypes they are used for.
Now they're all in the same place.
Calls to matchImpl whose SumType arguments have the same dimensions will now share instantiations, instead of having separate ones.
This reduces the number of templates instantiated by matchImpl in the common case where only one SumType is being matched on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR can be grouped into two categories:
matchImplto eliminate unnecessary instantiations.matchImpl.Altogether, these changes reduce the time taken to run
sumtype's test suite by about 14%.Performance data, from my personal laptop:
Before
dmd -unittest -main -run src/sumtype.dWith refactoring
dmd -unittest -main -run src/sumtype.dWith refactoring and fast path
dmd -unittest -main -run src/sumtype.d