fix: fixes infinit loop in checksum calculation due to integer overflow#1
Open
CheerThe2nd wants to merge 1 commit into
Open
fix: fixes infinit loop in checksum calculation due to integer overflow#1CheerThe2nd wants to merge 1 commit into
CheerThe2nd wants to merge 1 commit into
Conversation
Author
|
In hindsight you could also just use the same type, for the index, which is used to store the end condition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when using
nmea::sentence::validate(nmeaBlock);and the passednmeaBlockcontains 3 or more nmea sentences, the checksum generation inside ofnmea::sentence::validatehalts for ever. After investigating I noticted that, inside ofstd::string sentence::checksum, a for loop is started which uses a 8 bit unsigned integer as index. And the end condition, for previously named for loop, is bigger than 255. So the for loop can never end since the 8 bit index will keep overflowing back to 0. To Fix this a higher bit value should be used as index.This snippet will reproduce the issue if used on the old version: