Skip to content

Remove duplicate PID from component modal #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcvantol merged 1 commit into from
Sep 7, 2026
Merged

Remove duplicate PID from component modal #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/engineering_platform/assets/dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3581,7 +3581,6 @@ function showComponentModal(payload) {
componentDetailField(fields, t("component.launchd_label"), launchd.label);
componentDetailField(fields, t("component.lifecycle_owner"), launchd.label ? t("component.launch_agent") : null);
componentDetailField(fields, t("component.lifecycle_status"), launchdLifecycleState(launchd));
componentDetailField(fields, t("component.process_id"), launchd.pid);
componentDetailField(fields, t("component.last_stopped"), launchdLastStopped(launchd));
componentDetailField(fields, t("component.launch_agent"), launchd.plist_path);
componentDetailField(
Expand Down
2 changes: 1 addition & 1 deletion tests/engineering/dashboard.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7817,7 +7817,7 @@ test.describe("Engineering Status browser smoke", () => {
const content = page.locator("#componentModalContent");
await expect(content).toContainText("Lifecycle-beheerderLaunchAgent");
await expect(content).toContainText("Lifecycle-statusActief");
await expect(content).toContainText("PID321");
await expect(content.getByText("PID", { exact: true })).toHaveCount(0);
await expect(content).toContainText("Laatst gestoptNooit gestopt");
await expect(content).toContainText("Huidig geheugenPID 321: 2.0 MiB");
});
Expand Down
Loading