Skip to content

gate the two statically-detectable members of the one-door class #337

Description

@pdbethke

The recurring defect in this repo is a rule applied at one door and not its siblings. Most of that class cannot be caught statically and this issue does not claim otherwise. Two instances from round three can:

  1. A PRIMARY KEY whose column list omits a column added by a migration in the same file. That is round three's R3 exactly: a context column was added, the key was left narrow, INSERT OR REPLACE then had two contexts overwriting each other, and the poller looped forever — shipped on the strength of a comment I wrote asserting it was safe.

  2. A default constant substituted in more than one function instead of through a single normalizer. Round three's R4: Store.Save defaulted an empty status context and Runner.Run did not, so the forge and the store disagreed about which check had spoken. Policy.normalized() exists because of it.

Both are cheap checks over a single file. Neither is general. Ship them as narrow gates with negative controls, per the standing rule that a gate which cannot fail is not a gate.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions