fix(i18n): the retired vocabulary the rename pass left behind - #68
Open
pedro-pelicioni wants to merge 1 commit into
Open
fix(i18n): the retired vocabulary the rename pass left behind#68pedro-pelicioni wants to merge 1 commit into
pedro-pelicioni wants to merge 1 commit into
Conversation
A value-level sweep of every EN and PT message (keys excluded — those are not
user-visible, and several are still named `skirmish*`) turned up eleven strings
the earlier pass missed, most of them fixed in one locale and not the other:
lesson.incorrect EN "study the rune again"
lesson.doneSignedIn EN "the beacon flickers ... the Ledgerstone"
lesson.mentorUnavailable EN "away from the forge — the scroll's hints"
lesson.backToAct EN + PT, said "act" where the app says section
journey.player.branch.locked EN + PT, same
home.doors.campaign.progress PT "atos vencidos" vs EN "sections cleared"
onboarding.welcomeBody3 EN + PT "one small rune at a time"
onboarding.xpLevels[0].blurb EN + PT "never written a rune ... the Citadel"
onboarding.proofHeading PT "os anciões já forjaram muitos aprendizes"
pages.campaign.optionalNote PT still counted in "atos"
pages.cards.footnote PT still promised on-chain card claiming, which
EN deliberately dropped — the two locales were
describing different products
`landing.*` is deliberately untouched: the campaign genuinely still has acts,
champion cards and the Beholder, and the art is named for them. Only the words
the app itself no longer uses were aligned there, in the previous pass.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by sweeping every value in the EN and PT message trees (keys excluded
— those are not user-visible, and several are still named
skirmish*, which isfine). Eleven strings, most fixed in one locale and not the other:
lesson.incorrectlesson.doneSignedInlesson.mentorUnavailablelesson.backToActjourney.player.branch.lockedhome.doors.campaign.progressonboarding.welcomeBody3onboarding.xpLevels[0].blurbonboarding.proofHeadingpages.campaign.optionalNotepages.cards.footnoteThat last one mattered most: the two locales were describing different products.
landing.*is deliberately untouched. The campaign genuinely still has acts,champion cards and the Beholder, and the art is named for them — only the words
the app itself no longer uses were aligned there, in the previous pass. Whether
the landing should stop selling the campaign framing altogether is a positioning
decision, not a consistency bug.
pages.track.overlordis left as"{overlord}": it is a format string, andevery act now has
overlord: null, so it never renders.