chore: remove eslint-disable comments - #111
Merged
Merged
Conversation
The disables were papering over nextjs/no-img-element firing outside its scope. Docs now uses next/image (unoptimized, SVG logos); demo-vite gets a scoped oxlint override since next/image does not exist in a Vite app; the landing array-index-key disable was dead weight.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint-disablecomments from source filesapps/docs: replace<img>logos withnext/image<Image unoptimized>(docs is a Next app, sonextjs/no-img-elementis legitimate there;unoptimizedbecause the optimizer rejects SVGs by default)apps/demo-vite: scopedoxlint.config.tsoverride turningnextjs/no-img-elementoff for the Vite app, wherenext/imagecannot existapps/landing: drop thereact/no-array-index-keydisable outright; oxlint does not enforce that rule hereVerification
pnpm verify21/21 (lint 0/0 across all workspaces, typecheck, tests, build)pnpm format:checkcleannext/imageswap