docs(code-review): retire the plan, keep the decisions it held - #83
Merged
Conversation
Four notes promoted, two re-verified with their drifted pointers corrected, one deleted and replaced because its name asserted a claim that had gone false, three candidates rejected. The curator runs in its own process against the candidates and the matching slice of the index, never a session transcript, so this is its judgement rather than the judgement of whichever session happened to be exhausted when the backlog was cleared.
Everything the plan described is built, and a plan that describes shipped code is a second account of it — one nobody updates, and one a reader has to reconcile against the code to find out which is current. The ADRs and CONTEXT.md carry what is hard to reverse; the plan carried what was next. Its rejected alternatives are not disposable, though: recording the rejected alternative is the decision's content, and four of them had no ADR. ADR 0010 takes them — the rung ladder, repo-declared content patterns, nested condition combinators, and implicit AND across a rule's keys — with the reasoning and the outside evidence intact. The fifth already traced to ADR 0004. Two comments pointed at the document rather than stating what they meant, which is what made the removal load-bearing rather than mechanical. Both now say the thing itself.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pieces of housekeeping now that
approvehas landed.The plan is retired
docs/plans/code-review.mddescribed work that is now built, all eight sections of it. A plan that describes shipped code is a second account of it — one nobody updates, and one a reader has to reconcile against the code to learn which is current. The ADRs carry what is hard to reverse andCONTEXT.mdcarries the vocabulary; the plan carried what was next, and there is no next.Its rejected alternatives are not disposable
CLAUDE.mdsays ADRs are the one place where recording the rejected alternative is the decision's content. §6 held five, and four had no ADR to fall back on — deleting the file would have left them recoverable only from git history, which is not where anyone looks before re-proposing an idea.ADR 0010 — Escalation is rules a person reads, not a ladder a model climbs takes them:
deep-code-review's size-class-plus-signal-count arithmetic does not survive: it exists because a model invokes that skill from a session where nobody chose a depth, and here a person typed the command having just decided the change is ready. Its inputs survive as escalation conditions; the arithmetic does not.concurrencyitself. A repo that writessync\.Mutexgets nothing the day it adds another language.The fifth, reviewers as a ninth definition category, already traced to ADR 0004 and is cross-referenced rather than restated.
The ADR is written forward, as a decision rather than as a summary of a deleted document, and its consequences section carries the one that matters next: a skill wrapping this engine does not size the review.
Two comments that pointed at the document
internal/reviewrun/prompt.gosaid "for the reason the plan gives" andinternal/reviewrun/thread_test.gosaid "The table in the plan, whole". Both now state the reason instead of pointing at it — which is whatCLAUDE.mdasks of a comment anyway, and what made this removal load-bearing rather than mechanical.Memory curation
Separate commit. Backlog to zero: four notes promoted, two re-verified with drifted line pointers corrected, one deleted and replaced because its name asserted a claim that had gone false, three candidates rejected.
agtk memory lint: 28 ok, index current.One promoted note is about the PR that preceded this one —
credential-guards-are-hand-maintained-listsrecords that three of the guards incredential_surface_test.goare scoped to hand-typed package slices, so a new sibling package is not walked and nothing fails.make checkgreen.