fix(approve): name --force only where a run is actually suppressed - #88
Open
pedromvgomes wants to merge 1 commit into
Open
fix(approve): name --force only where a run is actually suppressed#88pedromvgomes wants to merge 1 commit into
pedromvgomes wants to merge 1 commit into
Conversation
A refusal for a review that reached no verdict told the reader to re-run with --force. Suppression now passes exactly that case, so the flag is an override nothing is stopping them without — and telling a person to force their way past a review that examined nothing is the advice the complete verdict distinction exists to stop giving. The remedy keys off the marker instead. unanswered() runs for complete and incomplete markers alike, so its re-post remedy takes the same treatment rather than a blanket edit: a complete review does suppress, and there --force is still the only way through.
|
There was a problem hiding this comment.
Review by agtk — panel standard-codex
No findings survived the panel.
Ran and reported nothing: correctness-codex, security-codex
Absent from the reviewed copy (1): a symlink, a submodule or a file too large to read is not code this review looked at.
panel standard-codex, 3 runs, 1 convention docs read · range main...d1eaf23677d198a3baf059ad79226d14617cf5c3 · manifest built-in default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refusal for a review that reached no verdict told the reader to re-run with
--force:Since v0.12.1 that is the one case a plain run passes: a no-verdict review no longer suppresses the next one. So the flag is an override nothing is stopping them without — and telling a person to force their way past a review that examined nothing is exactly the advice the complete-verdict distinction exists to stop giving.
Not a find-and-replace
gate.gonames--forcein two remedies and only one is wrong.unanswered()runs for complete and incomplete markers alike, so its "carries no thread" remedy has to answer the same question rather than be edited alongside. A complete review does suppress a re-run, and there--forceis still the only way through.Both now go through
rerunRemedy(number, complete), which names the flag in the one case a plain run declines to pass.Tests
TestTheRemedyForANoVerdictReviewDoesNotReachForForce— confirmed to fail against the previous string.TestAFindingWithNoThreadOnACompleteReviewStillNeedsForce— pins the case that must keep it, so a later simplification cannot quietly drop--forcewhere it is load-bearing.make checkgreen. Reviewed locally before pushing: no findings.