[Histogram] Fix off-by-one boundary bug#143
Merged
thinkingfish merged 1 commit intopelikan-io:mainfrom Jan 12, 2026
Merged
Conversation
thinkingfish
approved these changes
Jan 12, 2026
Member
thinkingfish
left a comment
thinkingfish
left a comment
There was a problem hiding this comment.
Thank you for catching and fixing this bug!
Contributor
Author
You're welcome! Would it be possible to cut a patch release that includes this change? |
Member
|
Published a new release with the fix. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #142
Problem
Function
value_to_indexis not working correctly which can result to a index out of bounds panic. That's becausemaxvariable is set incorrectly (off-by-one). Case formax_value_power == 64is already correct asu64::MAX==2^64 - 1.Solution
Set
maxvariable to be an inclusive boundary (2^n - 1).