fix(contacts): edit contact creates duplicate [PERA-3989]#371
Merged
Conversation
- saveContact: insert-only → upsert (functional set). - Schema: id and image optional so edits round-trip the id. - deleteContact: simplified; setContacts removed (unused).
5 tasks
yasin-ce
requested review from
fmsouza,
wjbeau and
yasincaliskan
and removed request for
wjbeau
wjbeau
approved these changes
Apr 24, 2026
… review Instead of the UI hooks calling findContacts to guard against duplicate addresses, saveContact now enforces uniqueness at the store layer and throws DuplicateAddressError on conflict. Downstream hooks catch and surface to form state. Addresses PR #373 review comment to keep business rules in the package, not the UI layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
Additional Notes
Bottom of a 7-PR stack (base: `main`). Every downstream PR (#372 → #377) depends on this store behavior — please land this first.