fix: show asset suggestions on empty Add Asset query [PERA-4159]#390
Closed
fix: show asset suggestions on empty Add Asset query [PERA-4159]#390
Conversation
Match Android: when the Add Asset / Add Collectible search field is empty, fetch the backend's default suggestion list instead of leaving the screen blank. Adds a `showOnEmptyQuery` opt-in to `useGlobalSearch` so the remote asset query runs (and surfaces loading) without typed input, and omits the `q` parameter from `/v1/assets/search/` when it's blank so the API returns suggestions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showOnEmptyQueryopt-in touseGlobalSearchso the remote asset query runs (and surfaces loading) without typed input. Local sections (accounts/contacts/owned assets) remain empty until the user types.qparameter from/v1/assets/search/when it's blank so the API returns suggestions (Android sendsqasnull, which Retrofit drops; RN was sendingq='').Test plan
pnpm buildpasses (tsc).useGlobalSearchand assets endpoint test suites pass with new coverage.🤖 Generated with Claude Code