Skip to content

fix: slippage and pera fee display in swap [PERA-4082]#392

Merged
yasincaliskan merged 1 commit intomainfrom
yasincaliskan/PERA-4082
Apr 28, 2026
Merged

fix: slippage and pera fee display in swap [PERA-4082]#392
yasincaliskan merged 1 commit intomainfrom
yasincaliskan/PERA-4082

Conversation

@yasincaliskan
Copy link
Copy Markdown
Collaborator

@yasincaliskan yasincaliskan commented Apr 28, 2026

Description

  • Slippage was rendering the raw API fraction (0.05) instead of a percent (5%)
  • Pera fee always used assetIn for the symbol. Added peraFeeAsset to SwapQuote and fall back to assetIn only when absent

Related Issues

Checklist

  • Have you tested your changes locally?
  • Have you reviewed the code for any potential issues?
  • Have you documented any necessary changes in the project's documentation?
  • Have you added any necessary tests for your changes?
  • Have you updated any relevant dependencies?

@yasincaliskan yasincaliskan requested review from fmsouza and wjbeau April 28, 2026 09:37
@yasincaliskan yasincaliskan self-assigned this Apr 28, 2026
@yasincaliskan yasincaliskan merged commit 8d2e04b into main Apr 28, 2026
8 checks passed
@yasincaliskan yasincaliskan deleted the yasincaliskan/PERA-4082 branch April 28, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjbeau wjbeau wjbeau approved these changes

@fmsouza fmsouza Awaiting requested review from fmsouza

Assignees

@yasincaliskan yasincaliskan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yasincaliskan @wjbeau