Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades Grafana dependencies from version 11.5.2 to 12.3.1 and includes necessary compatibility adjustments. The changes also include test improvements to handle parallel test execution better.
Changes:
- Upgraded @grafana packages from 11.5.2 to 12.3.1 in pmm-compat
- Updated UI styles and locators to match Grafana 12.3.1's updated interface elements
- Improved test reliability by addressing concurrency issues in API tests
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/apps/pmm-compat/package.json | Updated @grafana package versions from 11.5.2 to 12.3.1 |
| ui/apps/pmm-compat/src/lib/constants.ts | Updated search button label and added new docked menu local storage key |
| ui/apps/pmm-compat/src/compat.ts | Added initialization of new Grafana docked menu local storage key |
| ui/apps/pmm-compat/src/styles.ts | Added CSS rule to hide separator elements adjacent to hidden toolbar buttons |
| api-tests/user/snooze_test.go | Enhanced test to handle shared state from parallel test execution |
| api-tests/server/readyz_test.go | Fixed potential race condition by copying BaseURL instead of parsing it |
| api-tests/management/nodes_test.go | Made error message assertion more flexible to handle JSON serialization variations |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
matejkubinec
approved these changes
Jan 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #4976 +/- ##
==========================================
- Coverage 47.79% 47.70% -0.09%
==========================================
Files 410 410
Lines 41981 41981
==========================================
- Hits 20066 20029 -37
- Misses 19939 19972 +33
- Partials 1976 1980 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14213