Skip to content

PMM-14213 Grafana 12.3.1#4976

Open
fabio-silva wants to merge 31 commits intov3from
PMM-14213-grafana-12.3.1
Open

PMM-14213 Grafana 12.3.1#4976
fabio-silva wants to merge 31 commits intov3from
PMM-14213-grafana-12.3.1

Conversation

@fabio-silva
Copy link
Copy Markdown
Contributor

@fabio-silva fabio-silva commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades Grafana dependencies from version 11.5.2 to 12.3.1 and includes necessary compatibility adjustments. The changes also include test improvements to handle parallel test execution better.

Changes:

  • Upgraded @grafana packages from 11.5.2 to 12.3.1 in pmm-compat
  • Updated UI styles and locators to match Grafana 12.3.1's updated interface elements
  • Improved test reliability by addressing concurrency issues in API tests

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ui/apps/pmm-compat/package.json Updated @grafana package versions from 11.5.2 to 12.3.1
ui/apps/pmm-compat/src/lib/constants.ts Updated search button label and added new docked menu local storage key
ui/apps/pmm-compat/src/compat.ts Added initialization of new Grafana docked menu local storage key
ui/apps/pmm-compat/src/styles.ts Added CSS rule to hide separator elements adjacent to hidden toolbar buttons
api-tests/user/snooze_test.go Enhanced test to handle shared state from parallel test execution
api-tests/server/readyz_test.go Fixed potential race condition by copying BaseURL instead of parsing it
api-tests/management/nodes_test.go Made error message assertion more flexible to handle JSON serialization variations

@ademidoff ademidoff changed the title Pmm 14213 grafana 12.3.1 PMM-14213 Grafana 12.3.1 Jan 29, 2026
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 5, 2026

CLA assistant check
All committers have signed the CLA.

@fabio-silva fabio-silva requested a review from Nailya as a code owner April 9, 2026 11:01
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.70%. Comparing base (5c623d1) to head (67edf8d).
⚠️ Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #4976      +/-   ##
==========================================
- Coverage   47.79%   47.70%   -0.09%     
==========================================
  Files         410      410              
  Lines       41981    41981              
==========================================
- Hits        20066    20029      -37     
- Misses      19939    19972      +33     
- Partials     1976     1980       +4     
Flag Coverage Δ
admin 35.80% <ø> (ø)
agent 53.00% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants