PMM-14962 Avoid printing sensitive info into log stream#5205
Open
PMM-14962 Avoid printing sensitive info into log stream#5205
Conversation
- New Protobuf extension is introduced `redact` that contains several values: -- REDACT_TYPE_FULL - fully replace string value with redact mask -- REDACT_TYPE_MASK - partially replace string value with redact mask -- REDACT_TYPE_DSN - replace credentials only in DSN with redact mask - Our protobuf message fields were annotated accordingly.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v3 #5205 +/- ##
==========================================
- Coverage 47.75% 47.67% -0.08%
==========================================
Files 410 410
Lines 41981 41985 +4
==========================================
- Hits 20046 20015 -31
+ Misses 19957 19943 -14
- Partials 1978 2027 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JiriCtvrtka
approved these changes
Apr 6, 2026
ademidoff
requested changes
Apr 8, 2026
Member
ademidoff
left a comment
There was a problem hiding this comment.
Good job! What is the performance implication of this?
Contributor
Author
Results from benchmark tests: But there are points:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14962
Link to the Feature Build: Percona-Lab/pmm-submodules#4290
sensitivethat contains several values:logger.RedactMessagethat shall be used in case proto message shall be printing into log stream. It does: