Skip to content

PMM-14887 Provide a Docker Compose file for community#5212

Open
ademidoff wants to merge 25 commits intov3from
PMM-14887-restructure-project-makefiles
Open

PMM-14887 Provide a Docker Compose file for community#5212
ademidoff wants to merge 25 commits intov3from
PMM-14887-restructure-project-makefiles

Conversation

@ademidoff
Copy link
Copy Markdown
Member

@ademidoff ademidoff commented Apr 3, 2026

PMM-14887

Link to the Feature Build: SUBMODULES-4291

The PR fixes a panic when the users starts the container with empty parameters, for example: PMM_CLICKHOUSE_ADDR=${PMM_CLICKHOUSE_ADDR:-}. There is a flaw in how managed treats empty variables, being unable to set the default value.

time="2026-04-09T19:00:59.780+00:00" level=warning msg="ClickHouse DB is not reachable [tcp://default:xxxxx@127.0.0.1:9000/pmm]: dial tcp 127.0.0.1:9000: connect: connection refused" component=telemetry
time="2026-04-09T19:00:59.782+00:00" level=info msg="Loading alerting templates from dir=/usr/local/percona/alerting-templates" component=management/alerting
time="2026-04-09T19:00:59.799+00:00" level=info msg="Updating settings..." component=setup
time="2026-04-09T19:00:59.803+00:00" level=info msg=Done. component=main
panic: runtime error: index out of range [1] with length 1

goroutine 1 [running]:
github.com/percona/pmm/managed/services/supervisord.(*Service).marshalConfig(0xc0006aa240, 0xc000069700, 0xc000576d80)
        /home/builder/rpm/BUILD/pmm-60284c9a56a29c76ac19a44936f8e6e1089a5a18/src/github.com/percona/pmm/managed/services/supervisord/supervisord.go:259 +0x1653
github.com/percona/pmm/managed/services/supervisord.(*Service).UpdateConfiguration(0xc0006aa240, 0xc000576d80)
        /home/builder/rpm/BUILD/pmm-60284c9a56a29c76ac19a44936f8e6e1089a5a18/src/github.com/percona/pmm/managed/services/supervisord/supervisord.go:401 +0x474
github.com/percona/pmm/managed/services/server.(*Server).UpdateConfigurations(0xc0005767e0, {0x27b1b88, 0xc00020b1a0})
        /home/builder/rpm/BUILD/pmm-60284c9a56a29c76ac19a44936f8e6e1089a5a18/src/github.com/percona/pmm/managed/services/server/server.go:798 +0xec
github.com/percona/pmm/managed/services/server.(*Server).UpdateSettingsFromEnv(0xc0005767e0, {0x27b1b88, 0xc00020b1a0}, {0xc000053040, 0x19, 0x19})
        /home/builder/rpm/BUILD/pmm-60284c9a56a29c76ac19a44936f8e6e1089a5a18/src/github.com/percona/pmm/managed/services/server/server.go:157 +0x23e
main.setup({0x27b1b88, 0xc00020b1a0}, 0xc0004c8880)
        /home/builder/rpm/BUILD/pmm-60284c9a56a29c76ac19a44936f8e6e1089a5a18/src/github.com/percona/pmm/managed/cmd/pmm-managed/main.go:530 +0x23a

This pull request introduces several improvements and updates to the development and CI/CD environment configuration for PMM Server and related components. The main changes focus on updating container images, enhancing environment variable documentation, and cleaning up or updating workflow and configuration files.

Development and CI/CD environment updates:

  • Updated default PMM Server image references to use percona/pmm-server:3 and ghcr.io/percona/pmm:3-dev-container in .env.example and GitHub Actions workflows for consistency and clarity. [1] [2] [3] [4]
  • Improved .env.example with detailed comments and organized sections for easier configuration of PMM Server, external databases, SMTP, Watchtower, and development options.

Container image and database version updates:

  • Updated MongoDB and PostgreSQL versions in agent/docker-compose.yml to use Percona Server for MongoDB 6.0 (from 5.0) and PostgreSQL 14 (from 11), ensuring the test environment uses more current database versions. [1] [2] [3] [4] [5]
  • Added pg_stat_statements extension initialization for PostgreSQL in dev/init-pg.sql.

Workflow and configuration cleanup:

  • Removed the spell-check job and its configuration (.typos.toml) from the CI workflow, streamlining the pipeline. [1] [2]
  • Minor improvements and typo fixes in documentation and environment variable descriptions for clarity and accuracy. [1] [2] [3] [4]

New and improved development scripts:

  • Added MySQL slow query logging configuration (dev/my.cnf), logrotate rules for slow logs (dev/mysql.logrotate), and a new sysbench script for Percona Server (dev/sysbench-ps.sh) to improve local development and testing capabilities. [1] [2] [3]

Other minor changes:

  • Updated or removed certain environment variables and public keys in various docker-compose files for better security and maintainability. [1] [2]
  • Minor documentation tweaks in README.md for improved clarity.

Let me know if you want to discuss any of these changes in more detail!

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.39%. Comparing base (ca3db34) to head (e8f8a03).

Files with missing lines Patch % Lines
managed/cmd/pmm-managed-init/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #5212      +/-   ##
==========================================
- Coverage   47.77%   47.39%   -0.38%     
==========================================
  Files         410      540     +130     
  Lines       41979    44323    +2344     
  Branches        0      584     +584     
==========================================
+ Hits        20054    21009     +955     
- Misses      19949    21269    +1320     
- Partials     1976     2045      +69     
Flag Coverage Δ
admin 35.80% <ø> (ø)
agent 53.12% <ø> (-0.13%) ⬇️
managed 47.71% <33.33%> (-0.01%) ⬇️
unittests 41.38% <ø> (?)
vmproxy 72.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@catalinaadam catalinaadam temporarily deployed to PMM-14887-restructure-project-makefiles - pmm 3.7.0 PR #5212 April 3, 2026 10:38 — with Render Destroyed
git status


spell-check:
Copy link
Copy Markdown
Member Author

@ademidoff ademidoff Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Practically no value from this, better use AI, e.g. Copilot reviews.

@ademidoff ademidoff marked this pull request as ready for review April 6, 2026 11:23
@ademidoff ademidoff requested review from a team and Nailya as code owners April 6, 2026 11:23
@ademidoff ademidoff requested review from JiriCtvrtka, fabio-silva, matejkubinec and maxkondr and removed request for a team April 6, 2026 11:23
Copy link
Copy Markdown
Contributor

@maxkondr maxkondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first review iteration (not finished)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. what is the difference between env-up, env-compose-up ? when each of them shall be used?
  2. group targets by their meaning: init, development, testing, release preparation, etc

@ademidoff ademidoff force-pushed the PMM-14887-restructure-project-makefiles branch from acf4034 to 9ce6b0a Compare April 9, 2026 19:26
@ademidoff ademidoff changed the title PMM-14887 Restructure Makefiles PMM-14887 Provide a Docker Compose file for community Apr 9, 2026
@ademidoff ademidoff requested a review from maxkondr April 9, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants